round(): Validate the rounding mode

[TimWolla]

No description provided.

[TimWolla]

Previously an invalid rounding mode was considered to be equal to PHP_ROUND_HALF_UP. This is no longer the case since #12220. Making this a ValueError would be correct, but possibly a little steep. Shall I update this to a E_WARNING + change mode to PHP_ROUND_HALF_UP within the switch()? I don't want to update the rounding helper to handle unknown cases to keep the function clean.

[Girgias]

I think having it directly a ValueError is fine IMHO, just add an entry in UPGRADING

[staabm]

fwiw, this error is reported by PHPStan since phpstan/phpstan-src#1126

https://phpstan.org/r/0baee5fd-2e82-409b-812d-bff03b8a31df

[Girgias]

Aside, the precision arg seems to be truncating values, maybe as a follow-up this should do the usual boundary checks and throw a value error, or make the _php_math_round() take a zend_long instead of an int ?

[Girgias]

I think having it directly a ValueError is fine IMHO, just add an entry in UPGRADING

[TimWolla]

Aside, the precision arg seems to be truncating values, maybe as a follow-up this should do the usual boundary checks and throw a value error, or make the _php_math_round() take a zend_long instead of an int ?

Any values with more than 2 digits are useless anyway. It probably makes sense to validate this, but first we need to establish how many digits are actually meaningful. There some open PRs around this by @SakiTakamachi.

[SakiTakamachi]

Yes, I thought about these problems and finally found what I personally think is the best solution.
#12268