Skip to content

Fix str_decrement() on "1" #12339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix str_decrement() on "1" #12339

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 requested a review from Girgias October 1, 2023 16:12
@iluuu1994 iluuu1994 requested a review from bukka as a code owner October 1, 2023 16:12
@iluuu1994 iluuu1994 mentioned this pull request Oct 1, 2023
Merged
@iluuu1994
Copy link
Member Author

Oops, this should target 8.3 🙂 I'll rebase before merging.

Girgias
Girgias approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluuu1994 iluuu1994 closed this in b31a5b2 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @Girgias