Skip to content

Fix GH-11121: ReflectionFiber segfault #12391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-11121: ReflectionFiber segfault #12391

wants to merge 2 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 9, 2023

Fixes #11121 using the fix suggested by @bwoebi.

@Girgias Girgias requested review from trowski and bwoebi October 9, 2023 14:22
@trowski
Copy link
Member

trowski commented Oct 9, 2023

The setting of fiber->execute_data is misplaced, it shouldn't be part of the context API.

This would the preferred way: trowski@6cc5d31

Apparently I cannot push to this branch, so @danog if you'd be so kind as to grab that commit.

@trowski trowski force-pushed the fix_reflectionfiber_2 branch from 5335bad to eb0ebae Compare October 10, 2023 13:33
@trowski
Copy link
Member

trowski commented Oct 10, 2023

Thanks for giving me push access @danog! This is ready to merge.

@nielsdos nielsdos closed this in 71f1451 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski approved these changes

@bwoebi bwoebi Awaiting requested review from bwoebi

Assignees
No one assigned
Labels
Category: Fibers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danog @trowski @Girgias