Fix #49510: boolean validation fails with FILTER_NULL_ON_FAILURE #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix empty strings validation (treat it as correct false value).
|
It would be nice to add test to this. |
|
@zergin see @smalyshev comment about the test case. |
|
Tried to apply this pull request but the fix doesn’t resolves the issue as the PHP_FILTER_TRIM_DEFAULT() returns on empty string (or bool(false)). I have a fix locally that needs another pairs of eyes with a testcase. |
|
@lstrojny it still has no test. If you want to apply it, please add test. |
|
The fix wasn’t complete. Added a fix and a tests. Committed to PHP-5.4 and master. |
|
Comment on behalf of lstrojny at php.net: Bug fixed in PHP-5.4 and master. |
|
Sorry for the very long time with out a response. I've just got back to this case just to see it fixed under an hour ago ;-) Thank you very much. |
derickr
added a commit
that referenced
this pull request
Sep 14, 2022
- Fixed #124: Can't parse INT_MIN - Added a new API, timelib_get_time_zone_offset_info, which reduces allocation speeding up algorithms (Alberto Massari) - Accelerate the do_range_limit_days algorythm by advancing multiple months in a single call (Alberto Massari) Including fixes from 2021.17: - Fixed 'const' and other compiler warnings - Use new 'PACKRAT' format to prevent old timestamps from becoming incorrect - New 2022b data file - Fixed PHP GH-9165: strtotime translates a date-time with DST/non-DST hour differently
derickr
added a commit
that referenced
this pull request
Sep 14, 2022
iluuu1994
added a commit
that referenced
this pull request
Sep 15, 2022
iluuu1994
added a commit
that referenced
this pull request
Sep 15, 2022
* PHP-8.2: Backport skipping of ext/date/tests/gh-124.phpt on ASAN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49510: Fix empty strings validation (treat it as correct false value).