Skip to content

Fix: pdo pgsql test 12423 #12453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix: pdo pgsql test 12423 #12453

wants to merge 2 commits into from

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Oct 17, 2023 •
edited
Loading

Please see #12448

I missed the f push. It's a hassle, so I'll recreate the entire PR.

@SakiTakamachi SakiTakamachi force-pushed the fix/pdo_pgsql_test_12423 branch from b609033 to 722cc99 Compare October 17, 2023 08:37
@SakiTakamachi
Copy link
Member Author

CI: https://app.circleci.com/pipelines/github/SakiTakamachi/php-src/6/workflows/c8d0d36b-e61b-4bfd-b7cc-802a0a33d20b/jobs/6

@SakiTakamachi
Copy link
Member Author

@mbeccati @devnexen
Optimized the test. First, I would like to wait to see if my CI passes.

@mbeccati
Copy link
Contributor

Works for me:

SKIP GitHub #12424 (Fix GH-12423: [pdo_pgsql] Changed to prioritize DSN authentication information over arguments.) [ext/pdo_pgsql/tests/gh12423.phpt] reason: : no password

@SakiTakamachi
Copy link
Member Author

Thank you.
The line break when an error occurs is very hard to see, so I'll fix it a little more.

dstogov and others added 2 commits October 17, 2023 17:43
@dstogov @SakiTakamachi
Fixed phpGH-11917: primitives seem to be passed via reference instead…
4dcf063 
… of by value under some conditions when JIT is enabled on windows (php#12451)
@SakiTakamachi
Optimized pdo_pgsql connection test
a7dcc55 
add skip conditions

add line break on error, fix skip message
@SakiTakamachi SakiTakamachi force-pushed the fix/pdo_pgsql_test_12423 branch from 722cc99 to a7dcc55 Compare October 17, 2023 08:44
@SakiTakamachi SakiTakamachi deleted the fix/pdo_pgsql_test_12423 branch October 17, 2023 08:51
@SakiTakamachi SakiTakamachi mentioned this pull request Oct 17, 2023
Merged
@SakiTakamachi
Copy link
Member Author

I missed the f push. It's a hassle, so I'll recreate the entire PR and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees
No one assigned
Labels
Extension: opcache Extension: pdo_pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SakiTakamachi @mbeccati @dstogov