Skip to content

fix potential NULL pointer dereference #12506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix potential NULL pointer dereference #12506

wants to merge 4 commits into from

Conversation

icy17
Copy link
Contributor

@icy17 icy17 commented Oct 24, 2023

Fix potential NULL pointer dereference when calling xmlParseURIReference.

@devnexen
Copy link
Member

devnexen commented Oct 24, 2023

would it be possible to fix your branch please ?

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks right, thanks. I see for the openssl change a PR is already open.
I'll cherry-pick your last commit for the dom/xml{reader,writer} changes.

@nielsdos nielsdos closed this in 900f0ca Oct 24, 2023
@bukka
Copy link
Member

bukka commented Oct 24, 2023

There's still the OpenSSL one so please rebase it and I will get it merged - think EVP_DigestInit has such check but better to not call it with NULL anyway so the check is a good idea.

@bukka bukka reopened this Oct 24, 2023
@nielsdos
Copy link
Member

Ah I thought you were gonna merge it via the openssl-specific PR #12321

@icy17 icy17 closed this by deleting the head repository Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants