Skip to content

Fix unused variable in phpdbg_cmd.c #12575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix unused variable in phpdbg_cmd.c #12575

merged 1 commit into from
Oct 31, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Oct 30, 2023 •
edited
Loading 

/usr/src/php/sapi/phpdbg/phpdbg_cmd.c:743:14: warning: unused variable 'buf' [-Wunused-variable]
  743 |         char buf[PHPDBG_MAX_CMD];
      |              ^~~

@mvorisek
Copy link
Contributor Author

Am I right this fix should target master only?

nielsdos
nielsdos approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
And yes, targeting master is right as this is a warning fix not a bugfix.

@nielsdos nielsdos merged commit cc8c24a into php:master Oct 31, 2023
@mvorisek mvorisek deleted the fix_unused_phpdbg_sapi_var branch October 31, 2023 08:52
@SVGAnimate SVGAnimate mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @nielsdos