-
Notifications
You must be signed in to change notification settings - Fork 7.8k
ext/bcmath: optimized divmod()
and mod()
take 2
#18058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SakiTakamachi
wants to merge
13
commits into
php:master
Choose a base branch
from
SakiTakamachi:bcmath/mod_divmod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
345c1ed
to
d94dcc9
Compare
…o the correct value.
…ctions to use it.
430fb99
to
e91f32e
Compare
e91f32e
to
f76474e
Compare
e29f0f3
to
f0e9762
Compare
f0e9762
to
783c7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks
1:
2:
3:
div
In theory, it will be slower because there are more branches, but it seems to make little difference.
1:
2:
3:
divmod
This is faster because there are no extra calculations involved.
1:
2:
3:
mod
It's faster for the same reasons as divmod, and it's even faster because it doesn't need to generate
bc_num
for quot.1:
2:
3: