PGSQL: Allow unconditional selection in pg_select. #5332
Closed
+66
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nikic, not sure if you are the one to ping about this. It has been months since this was submitted without any review or feedback. Is there anything I need to do to get this reviewed? Should I post to the mailing list? |
|
Hi @OmarEmaraDev, sorry for late reply for your PR review. Could you please fix the conflicts ? I ll try to review it within the week-end. Cheers. |
devnexen
reviewed
Oct 7, 2023
devnexen
reviewed
Oct 8, 2023
|
Once the CI is finished, it would be nice if you could squash all your 7 commits into 1 it would be grand. |
Previously, pg_select did not allow unconditional selection, where an
empty ids array would result in a function failure.
This patch implements two changes:
- Make the ids array an optional parameter.
- Allow the ids array to be empty.
In both cases, unconditional selection happen, which is equivalent to
pg_query('SELECT * FROM <table>;').
Two test cases were added to test the aforementioned changes.
a6b2d6c to
e2c568e
Compare
devnexen
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
pg_selectdid not allow unconditional selection, where anempty ids array would result in a function failure.
This patch implements two changes:
In both cases, unconditional selection happen, which is equivalent to
pg_query('SELECT * FROM <table>;').Two test cases were added to test the aforementioned changes.