Convert shmop resources to opaque objects #5537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laruence
reviewed
May 8, 2020
We make `shmop_close()` a NOP, and deprecate the function right away; detaching from SHM now happens when the wrapper object is freed.
kocsismate
reviewed
Jun 8, 2020
| @@ -2,20 +2,17 @@ | |||
|
|
|||
| /** @generate-function-entries */ | |||
|
|
|||
| /** @return resource|false */ | |||
| function shmop_open(int $key, string $flags, int $mode, int $size) {} | |||
| final class Shmop {} | |||
There was a problem hiding this comment.
What do you think about using a class name like SharedMemoryBlock? For now, the chosen class name is mostly opaque, but if we end up adding an OO API, naming would play a more important role.
There was a problem hiding this comment.
I'm not against a more descriptive name, but Shmop has the advantage that it's short and also unlikely to collide.
41 tasks
|
Any objections? |
|
Thanks! Applied as 18f5808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make
shmop_close()a NOP, and deprecate the function right away;detaching from SHM now happens when the wrapper object is freed.