Skip to content

Dark mode for phpinfo() #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Dark mode for phpinfo() #7626

merged 1 commit into from
Nov 26, 2021

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Nov 6, 2021

Bildschirmfoto 2021-11-06 um 13 12 33

Light Bildschirmfoto 2021-11-06 um 13 11 47

@cmb69
Copy link
Member

cmb69 commented Nov 19, 2021

Thank you! This looks like a nice improvement to me. Are there any objections to merge this?

@MisterIcy
Copy link

Awesome!

Copy link

@mohammed-adil-moughal mohammed-adil-moughal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Improvement

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side.

@nikic nikic merged commit 35a01f8 into php:master Nov 26, 2021
@gharlan gharlan deleted the darkmode branch November 26, 2021 10:56
@morrisonlevi
Copy link
Contributor

Overall this is an interesting change we should keep. However, I think we should tweak these colors for more contrast. I'm not at a place to check right this moment, but I don't think it would meet standards for web accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants