Skip to content

CURL extension update proposal. #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

Allowing using CURLOPT_XFERINFOFUNCTION while deprecating CURLOPT_PROGRESSFUNCTION,
available since the 7.32 release.

@cmb69
Copy link
Member

cmb69 commented Dec 24, 2021

Thank you! This looks like a sensible improvement, except that we shouldn't probably deprecate CURLOPT_PROGRESSFUNCTION right away, so users have some time to update (if they even can; CentOS 7 still ships curl 7.29.0 by default). We can still deprecate this for 8.3 or so (and maybe require curl ≥ 7.32.0 then).

@devnexen
Copy link
Member Author

devnexen commented Apr 8, 2022

ping :)

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think it would make sense to add a test for the actual callback functionality. I.e. test that the function is actually called with sensible arguments.

@devnexen devnexen force-pushed the curl_interface_upd branch from cff40ae to 386f8eb Compare April 8, 2022 13:27
Allowing using CURLOPT_XFERINFOFUNCTION while deprecating CURLOPT_PROGRESSFUNCTION,
available since the 7.32 release.
@devnexen devnexen force-pushed the curl_interface_upd branch from 386f8eb to ad9cb0d Compare April 8, 2022 13:58
@devnexen
Copy link
Member Author

ping :)

@cmb69 cmb69 closed this in 7a45dcf Apr 22, 2022
@cmb69
Copy link
Member

cmb69 commented Apr 22, 2022

Thank you! (and sorry for the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants