Skip to content

random extension macOs handling update. #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

random extension macOs handling update. #7824

wants to merge 2 commits into from

Conversation

devnexen
Copy link
Member

Not such as fix but taking more precautions.
Indeed, the arc4random has two little flaws in this platform,
one already caught upfront by the extension (ie size 0), also
internal use of ccrng_generate which can silently fail in few rare
cases.

@devnexen
random extension macOs handling update.
a1597e4 
Not such as fix but taking more precautions.
Indeed, the arc4random has two little flaws in this platform,
one already caught upfront by the extension (ie size 0), also
internal use of ccrng_generate which can silently fail in few rare
cases.
@devnexen devnexen force-pushed the random_macos_update branch from afa6eec to a1597e4 Compare December 25, 2021 06:34
@devnexen
"backporting" my fix from openssl, anticipating issue with macOs <= 1…
d5e13ef 
…0.13

releases which need this header in addition.
@devnexen devnexen requested a review from nikic June 3, 2022 20:49
@devnexen devnexen requested a review from kocsismate June 14, 2022 08:04
@kocsismate
Copy link
Member

I've just checked https://opensource.apple.com/source/CommonCrypto/CommonCrypto-60165/include/Private/CommonRandomSPI.h.auto.html and I'm wondering why CCRandomGenerateBytes is marked with API_DEPRECATED_WITH_REPLACEMENT?

@devnexen
Copy link
Member Author

devnexen commented Jun 21, 2022 •
edited
Loading

Means CCRandomGenerateBytes replaces all of these old calls (they have been removed I can see in the header locally only the new api is available).

@TimWolla
Copy link
Member

TimWolla commented Jul 8, 2022

see also: #8094

@devnexen devnexen mentioned this pull request Jul 13, 2022
Closed
@devnexen devnexen closed this in d830a1f Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic Awaiting requested review from nikic

@kocsismate kocsismate Awaiting requested review from kocsismate

Assignees
No one assigned
Labels
Extension: standard Waiting on Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @kocsismate @TimWolla @ramsey