Skip to content

Assert generated files are up to date in CI #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Assert generated files are up to date in CI #8295

wants to merge 2 commits into from
+32 −6

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Apr 2, 2022 •
edited
Loading

prevent issues like #8151 (comment)

  • changes in stubs are detected
  • changes in Zend/zend_vm_execute.h are detected
  • also assert there are no residual non-git ignored files from tests

mvorisek
mvorisek commented Apr 2, 2022
View reviewed changes
@mvorisek mvorisek marked this pull request as draft April 2, 2022 01:08
iluuu1994
iluuu1994 approved these changes Apr 2, 2022
View reviewed changes
@mvorisek mvorisek changed the title Check generated files in CI Assert generated files are up to date in CI Apr 2, 2022
@mvorisek mvorisek force-pushed the patch-1 branch 2 times, most recently from 3ddd209 to 83dcdc6 Compare April 2, 2022 14:14
@mvorisek mvorisek changed the base branch from master to PHP-8.0 April 2, 2022 14:15
@mvorisek mvorisek force-pushed the patch-1 branch 2 times, most recently from e226d57 to 32ed1fa Compare April 2, 2022 21:00
@mvorisek mvorisek marked this pull request as ready for review April 2, 2022 21:00
@mvorisek mvorisek force-pushed the patch-1 branch 2 times, most recently from d937e50 to 1d32a9f Compare April 2, 2022 21:12
@cmb69
Copy link
Member

cmb69 commented Apr 4, 2022

Hmm, do we even have to run the scripts, or can we just compare the mtime of the respective files?

@mvorisek
Copy link
Contributor Author

mvorisek commented Apr 4, 2022

@cmb69 we should run them, there are fast and the output is stable, any change to to generators is now detected corectly as well

@cmb69
Copy link
Member

cmb69 commented Apr 4, 2022

we should run them, there are fast and the output is stable, any change to to generators is now detected corectly as well

Okay, no objections. :)

@mvorisek mvorisek mentioned this pull request Apr 11, 2022
Closed
@mvorisek
Copy link
Contributor Author

Who can merge this PR?

@iluuu1994
Copy link
Member

I will have another look later today. Please be patient.

@iluuu1994 iluuu1994 self-assigned this Apr 21, 2022
@iluuu1994 iluuu1994 closed this in 36de002 Apr 21, 2022
@mvorisek mvorisek deleted the patch-1 branch April 21, 2022 21:35
@mvorisek mvorisek mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees

@iluuu1994 iluuu1994

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvorisek @cmb69 @iluuu1994 @nikic