-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Test Windows x86 and x64 with Github Actions #8392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b465468
to
69f7c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving Windows CI to GH actions is very welcome. Thank you! @flavioheleno and @iluuu1994 already worked on that; not sure what's the status of that.
Anyhow, I suggest to keep AppVeyor CI for a while, so we can verify that the move is complete.
I started but didn't get very far. iluuu1994#10 I'm happy for anybody else to take over. |
I haven't gone too far either. Changes are here: flavioheleno@0ee6bc5 :-) |
49336d0
to
4da833f
Compare
🚀 🚀 tests run! guys, can you take care of the failing tests? also, x86 cannot compile :( |
On a very quick glance, this looks like a line ending issue. It might be necessary to checkout with LF.
The CI runs with |
47c8c69
to
874ba42
Compare
ab66b78
to
49c9870
Compare
what is wrong with 59e357a? previous commit has no issue, but if the if is removed, build fails with command syntax error |
Ah sorry, you actually removed the outer |
ae467dd
to
e5e678a
Compare
@cmb69 can you please help me with the one failing Windows test? |
d51ba97
to
c27feaa
Compare
c27feaa
to
fea5e38
Compare
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Move Windows testing to unified place - GitHub Actions
needs #9721 and #9744
AppVeyour (orig):

Github Actions (moved):
