Fix tmp file deletion in mysqli_pam_sha256_public_key_ini.phpt test

[mvorisek]

the 1st (revert) commit should be merged into PHP 8.0 branch

#8295 was designed to detect also residual/uncleaned tmp files from build/tests

it works with PHP 8.0 & master, but one test for PHP 8.1 has an issue:

for some reasons the mysqlnd.sha256_server_public_key="test_sha256_ini" config is not deleted by the CLEAN section

[mvorisek]

I located the issue, to fix it, do this:

1. cheery pick 400c605 into PHP 8.1 branch
2. revert 1dc6dba into PHP 8.0 branch
3. merge up
4. close this PR

[mvorisek]

@iluuu1994 can you please apply the fixes based on my last post here?

[iluuu1994]

I'm not convinced this check is worthwhile. It isn't a security or stability issue (which was the real motivation), and any skipped test is not checked, meaning if we only execute this check for certain environments only a sub-set of tests will be checked for cleaning up files.

[mvorisek]

it asserts that tests does not produce any residual files (files not ignored by .gitignore), yes, we check for env. we run it on, but it improves test quality, so if there is no downside, I think it is legit, see #8427 (comment), commit from step one was supposed to be commit into PHP 8.1, not master only, and my change will detect that

[ramsey]

I want to make sure I understand this...

• We should cherry-pick cba5e60 into PHP-8.0
• Merge up into PHP-8.1
• Then cherry-pick 0508def into PHP-8.1

Do I have that right?

[mvorisek]

@ramsey yes and thank you into getting into this

[mvorisek]

I want to make sure I understand this...

* We should cherry-pick [cba5e60](https://github.com/php/php-src/commit/cba5e609e43b8ea3dc5b4403e8c542c43b9a378e) into PHP-8.0

* Merge up into PHP-8.1

* Then cherry-pick [0508def](https://github.com/php/php-src/commit/0508def9a9a00456dee0569539f95ff80d6accfa) into PHP-8.1

Do I have that right?

The last step was already done by @kamil-tekiela, thank you. Now let's please cherry-pick cba5e60 into PHP-8.0, so the CI asserts tests produce no residual files after they are run. The issue, and that's why it the commit has been reverted by @iluuu1994, was fixed.

Then please close this PR.

[mvorisek]

closing in favor of #8977, thank you @iluuu1994