opcache: Use O_TMPFILE file lock if available#8634
Merged
dstogov merged 6 commits intophp:masterfrom Oct 9, 2023
Merged
Conversation
Use O_TMPFILE if the kernel supports it to create the lock fd, this has multiple advantages including not having to worry about naming, permissions and the assurance that it will always go away cleanly even on abnormal termination.
Member
|
Since I had to go look up |
Contributor
Author
This is not the correct manual page to reference. Use https://man7.org/linux/man-pages/man2/open.2.html. |
Member
|
Thanks for the clarification! |
dstogov
approved these changes
Oct 9, 2023
Member
dstogov
left a comment
There was a problem hiding this comment.
I don't see any problems.
Sorry, I missed this PR in May.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use O_TMPFILE if the kernel supports it to create the lock fd, this
has multiple advantages including not having to worry about naming,
permissions and the assurance that it will always go away cleanly
even on abnormal termination.