intl ICU C++ code modernisation, making it closer to C++11 #8650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
May 29, 2022
There was a problem hiding this comment.
I don't know too much C++, but two questions:
ICU says:
Do not use. This API is for internal use only.
Should we actually use this API?
Additionally, what would happen if override is not available? The function would no longer be virtual, so I'm assuming dynamic dispatch wouldn't work as expected?
Sure why not using it directly.
A C++11 compiler capable minimum is expected (g++ 4.9 at least, Visual Studio 2012/13) |
Girgias
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.