Skip to content

Fix GH-8661: Nullsafe in coalesce triggers undefined variable warning #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2022
Merged

Fix GH-8661: Nullsafe in coalesce triggers undefined variable warning #8690

merged 1 commit into from
Jun 12, 2022
+70 −28

Conversation

iluuu1994
Copy link
Member

Targeting master as this could break == comparison of extended_value of JMP_NULL in extensions.

@iluuu1994 iluuu1994 force-pushed the gh-8661-nullsafe-in-coalesce-triggers-undefined-variable branch from 2840e8e to 8bed5b2 Compare June 2, 2022 15:25
@iluuu1994 iluuu1994 requested review from Girgias and kocsismate June 2, 2022 16:20
@iluuu1994 iluuu1994 added this to the PHP 8.2 milestone Jun 3, 2022
@iluuu1994 iluuu1994 requested a review from arnaud-lb June 7, 2022 14:02
@arnaud-lb
Copy link
Member

I will review by friday

arnaud-lb
arnaud-lb approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Girgias
Girgias approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluuu1994 iluuu1994 force-pushed the gh-8661-nullsafe-in-coalesce-triggers-undefined-variable branch from 8bed5b2 to 5a855ee Compare June 12, 2022 19:54
@iluuu1994 iluuu1994 closed this in 5a855ee Jun 12, 2022
@iluuu1994 iluuu1994 merged commit 5a855ee into php:master Jun 12, 2022
@rajyan
Copy link

rajyan commented Jun 12, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate

Assignees
No one assigned
Labels
Category: Engine Category: Optimizer
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@iluuu1994 @arnaud-lb @rajyan @Girgias @adoy