Skip to content

Add test for backtrace with aliased trait #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 4, 2022

see https://3v4l.org/uVm7l, in PHP 7.4, backtrace was wrong when private aliased method was redeclared in child class

I belive this was fixed in 53efa1b

but there is only one test /w Reflection

this test asserts the backtrace is correct as some frameworks may assert some security features on it

@mvorisek mvorisek marked this pull request as ready for review June 4, 2022 13:55
@mvorisek
Copy link
Contributor Author

are there any objections before merging?

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the test isn't about actual reflection, I'd put it under Zend/tests. Otherwise this is good to me.

@mvorisek
Copy link
Contributor Author

Test moved

@arnaud-lb arnaud-lb merged commit f26f6d9 into php:master Jun 30, 2022
@arnaud-lb
Copy link
Member

Thank you!

@mvorisek mvorisek deleted the aliased_bt branch July 1, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants