Add deprecation notices to utf8_encode and utf8_decode #8726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
approved these changes
Jun 8, 2022
|
Actually, I've been lazy here: some of those tests aren't supposed to be testing the deprecated functions, so should be fixed rather than blessed. I'll have another look tomorrow. |
Implements initial stage of accepted RFC to remove them: https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode Tests relating to SOAP and htmlspecialchars seem to have been using this entirely unnecessarily, so have been fixed.
2b6ef67 to
0192b2e
Compare
|
Updated with some tests rewritten which were using the deprecated functions in exactly the nonsensical ways that made me want to deprecate them. |
LGTM! Can you please merge it and add the NEWS entry? |
|
Thank you! |
|
The status in the RFC should be updated. It still reads "Pending implementation" (and is also listed in the "Accepted" section on the RFC list). |
|
I've updated and moved the RFC just now. |
|
Oh, thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements initial stage of accepted RFC to remove them:
https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode