Skip to content

Add clean_module_functions() #8763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Conversation

twose
Copy link
Member

@twose twose commented Jun 13, 2022

Add clean_module_functions() to clean functions which are registered by zend_register_functions().
The general logic of clean_module_functions() is consistent with clean_module_classes().

@twose
Copy link
Member Author

twose commented Jun 14, 2022

Here we need dl() an extension that uses zend_register_functions() directly.
I can't think of any low-cost testing way for the time being...

@devnexen devnexen requested a review from arnaud-lb June 14, 2022 18:21
@arnaud-lb
Copy link
Member

arnaud-lb commented Jun 14, 2022

You can use the dl_test extension for testing this. You can add some zend_register_function() calls if needed.

@twose twose force-pushed the fix_clean_module_function branch from 96fa486 to 0c6894d Compare June 15, 2022 11:47
Add clean_module_functions() to clean functions which are registered by zend_register_functions().
The general logic of clean_module_functions() is consistent with clean_module_classes().
@twose twose force-pushed the fix_clean_module_function branch from 0c6894d to b202752 Compare June 15, 2022 11:50
@twose
Copy link
Member Author

twose commented Jun 15, 2022

You can use the dl_test extension for testing this. You can add some zend_register_function() calls if needed.

@arnaud-lb Thank you for pointing this out!

Here is the test results:

image
image

@arnaud-lb arnaud-lb merged commit 4a9c001 into php:master Jun 17, 2022
@arnaud-lb
Copy link
Member

Thank you @twose !

I've just added a comment and moved the test to ext/standard/general_functions because this is the other dl() tests are (ext/dl_test/tests is for testing the extension itself)

@twose twose deleted the fix_clean_module_function branch June 18, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants