Specify unit in out of memory error #8820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
approved these changes
Jun 17, 2022
|
I'm not too happy with the error message generally, and duplicating "bytes" doesn't make it better, in my opinion. Can't we come up with something else? OTOH, certainly not a hill to die upon for me. |
|
I'll try to come up with something better. |
|
also the number should be converted to human format (with KB, MB, GB, ... unit) |
Girgias
reviewed
Jun 18, 2022
| #else | ||
| zend_mm_safe_error(heap, "Out of memory (allocated %zu) (tried to allocate %zu bytes)", heap->real_size, ZEND_MM_PAGE_SIZE * pages_count); | ||
| zend_mm_safe_error(heap, "Out of memory (allocated %zu bytes) (tried to allocate %zu bytes)", heap->real_size, ZEND_MM_PAGE_SIZE * pages_count); |
There was a problem hiding this comment.
Suggested change
| zend_mm_safe_error(heap, "Out of memory (allocated %zu bytes) (tried to allocate %zu bytes)", heap->real_size, ZEND_MM_PAGE_SIZE * pages_count); | |
| zend_mm_safe_error(heap, "Out of memory while trying to allocate %zu bytes (allocated %zu bytes)", ZEND_MM_PAGE_SIZE * pages_count, heap->real_size); |
Maybe?
|
I've merged because we can always improve the error message later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-8808