Add reallocarray implementation.
#8871
Closed
+54
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a similar model as _safe_*alloc api but for the `userland` it guards against overflow before (re)allocation, usage concealed in fpm for now. Modern Linux and most of BSD already have it.
|
Might it make sense to move this to zend_alloc.h/c? Maybe it could also take the persistent flag and the call pemalloc to make to make it more generally usable? The name could also be something like safe_pemalloc_try or similar to make it more discoverable for people who know the existing functions. Let's see what others think first. |
|
I think zend_alloc.c is not the proper place for this polyfill. However, if we were to add a ereallocarray() / pereallocarray(), these functions would belong in zend_alloc.c/h. |
Exactly, goal is to be used just like the libc's realloc. Saying this another PR could add a similar part, feature-wise, in the zend's side. |
iluuu1994
reviewed
Jun 25, 2022
iluuu1994
reviewed
Jun 26, 2022
1bdd07e to
21fc74b
Compare
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jun 27, 2022
Sort of php#8871 follow-up but on the zend part.
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jul 2, 2022
Sort of php#8871 follow-up but on the zend part.
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jul 2, 2022
Sort of php#8871 follow-up but on the zend part.
This was referenced Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar model as safe*alloc api but for the
userlandit guardsagainst overflow before (re)allocation, usage concealed in fpm for now.
Modern Linux and most of BSD already have it.