Skip to content

gnu compilers remove hot attribute proposal. #8922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jul 4, 2022

while the cold attribute has its place, the hot one however
does not have real justification for use even more so with
modern toolchains.

while the cold attribute has its place, the hot one however
does one have real justification for use even more so with
modern toolchains.
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent to this. It's not a big problem in keeping ZEND_HOT or removing it.

@Girgias Girgias merged commit 90b0e77 into php:master Jan 25, 2023
@Girgias Girgias removed the request for review from dstogov January 25, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants