Fix GH-8576: Bad interpretation of length when char is UTF-8 #8926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For columns of type `SQL_TEXT`, Firebird does not properly report the actual column length, but rather only the maximum column length, so for multi-byte encodings like UTF-8, such columns may have trailing spaces. We work around that by treating such columns as `SQL_VARYING` when we ask the server to describe the colum, what yields the desired results. Given that this is a work-around, and may break code which expects the results with trailing spaces, we target "master" only.
|
The FreeBSD CI issues are unrelated to this PR. The test passes on AppVeyor. |
devnexen
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For columns of type
SQL_TEXT, Firebird does not properly report theactual column length, but rather only the maximum column length, so for
multi-byte encodings like UTF-8, such columns may have trailing
spaces. We work around that by treating such columns as
SQL_VARYINGwhen we ask the server to describe the colum, what yields the desired
results.
Given that this is a work-around, and may break code which expects the
results with trailing spaces, we target "master" only.