QA - Test Cov - ext:pcntl - pcntl_signal() - max signal allowed

[juan-morales]

Extension: pcntl
Function: pcntl_signal
Description:
When provided the $signal parameter is greater than allowed in operating system, then expect an error.

I hard-coded the number 1000000 on purpose because I cannot find a constant or function that can give me the max allowed in order to increment it.

Please, all advices are welcome.

I also attach what was covered in the following screenshots:

Before

After

[cmb69]

signals are of type int, i.e. for our purposes always signed 32bit numbers. So using 2147483648 would definitely work, but not on 32bit architectures (that number would be represented as float there). Anyhow, 1000000 should be large enough for all systems.

[juan-morales]

@cmb69 @Girgias can you support me here? How can I see what happened for MAC and FreeBSD so I understand why failed for them?

[Girgias]

@cmb69 @Girgias can you support me here? How can I see what happened for MAC and FreeBSD so I understand why failed for them?

Just look at the build log, as the test diff will be shown

[juan-morales]

@cmb69 @Girgias can you support me here? How can I see what happened for MAC and FreeBSD so I understand why failed for them?

Just look at the build log, as the test diff will be shown

Thanks. I never notice that.

Change is ready for review again.

[Girgias]

Thank you :)

[juan-morales]

Thank you :)

To you and @cmb69 ... a lot.

I will continue adding more coverage to our code.