Skip to content

FPM fix strict prototype warnings #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FPM fix strict prototype warnings #8986

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

No description provided.

cmb69
cmb69 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM, but maybe @bukka wants to have a look.

@bukka
Copy link
Member

bukka commented Jul 17, 2022

If you are already changing those lines, it might be good to also remove /* {{{ */ and follow up /* }}} */ in those functions.

@devnexen devnexen force-pushed the fpm_noneprotofix branch 2 times, most recently from 03862ed to f6eba96 Compare July 18, 2022 06:51
@devnexen
Copy link
Member Author

@bukka you happy with the changes ? :-)

bukka
bukka approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry somehow forgot about it. This looks good to me.

@devnexen devnexen closed this in e2a5428 Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @bukka @cmb69