QA - pcntl_exec - check stringable parameters error #8990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to proceed in this cases? Another test is failing (not mine):
|
cmb69
reviewed
Jul 13, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward on this trip to add more coverage to our code now this change is presented.
Extension: pcntl
Function: pcntl_exec
If non-stringable arguments are passed to $args or $env_vars then exception is thrown (Fatal Error).
Instead to let the error explote, I catched them, also to test that the kind of error generated can be catch.
I attach the coverage gained.
Before
After
