QA - pcntl_setpriority() - adjust error/code coverage #8994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails in Mac like:
but the test is catching the error supposely:
Other tests (in other PULL REQUESTS) are having the same behavior too. Need support |
|
For FreeBSD ... seems that tests are running with root user?
In my test I wanted to cover the: That is why I usd PID = 1, which in Linux at least always belongs to root-system process Should I SKIP if OS is not FreeBSD ? |
|
As I wrote in #8993 ... I Will have a PR for this soon. |
|
will be fix in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the existing test that checks for errors on the pcntl_setpriority() function.
Extension: pcntl
Function: pcntl_setpriority
Also code coverage was improved.
Before
After
