Skip to content

DatePeriod properties cannot be made readonly #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate requested a review from derickr July 14, 2022 17:33
@kocsismate kocsismate added this to the PHP 8.2 milestone Jul 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9013 (af15923) into master (af15923) will not change coverage.
The diff coverage is n/a.

❗ Current head af15923 differs from pull request most recent head 59b3cce. Consider uploading reports for the commit 59b3cce to get more accurate results

@@           Coverage Diff           @@
##           master    #9013   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         829      829           
  Lines      310687   310687           
=======================================
  Hits       208352   208352           
  Misses     102335   102335           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kocsismate kocsismate force-pushed the date-period-revert-readonly branch from 59b3cce to 6557743 Compare July 19, 2022 06:25
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kocsismate kocsismate merged commit e13d60c into php:master Jul 19, 2022
@kocsismate kocsismate deleted the date-period-revert-readonly branch July 19, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants