Skip to content

Declare ext/openssl constants in stubs #9046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2022
Merged

Declare ext/openssl constants in stubs #9046

merged 2 commits into from
Jul 20, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate requested a review from bukka July 19, 2022 08:48
@kocsismate kocsismate changed the title Declare ext/openssl constants in stubs WIP Declare ext/openssl constants in stubs Jul 19, 2022
bukka
bukka requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@bukka bukka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those cnames are incorrect in many constants so this won't probably even build. Please go through it properly as the name often doesn't match the cname in openssl ext constants.

@kocsismate kocsismate changed the title WIP Declare ext/openssl constants in stubs Declare ext/openssl constants in stubs Jul 19, 2022
@kocsismate
Copy link
Member Author

Those cnames are incorrect in many constants so this won't probably even build. Please go through it properly as the name often doesn't match the cname in openssl ext constants.

Sorry, I opened the PR a bit prematurely as I didn't yet have time to review my changes. Now, I properly checked all the constants, so the PR should be good now.

@kocsismate kocsismate merged commit b358834 into php:master Jul 20, 2022
@kocsismate kocsismate deleted the const-openssl branch July 20, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

Assignees
No one assigned
Labels
Extension: openssl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @bukka