phpinfo HTML Output: Make module title names clickable and link to the URL fragment
#9054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
approved these changes
Jul 19, 2022
cmb69
reviewed
Jul 20, 2022
ext/standard/tests/general_functions/phpinfo-header-anchors.phpt
Outdated
Show resolved
Hide resolved
…the URL fragment Each section of `phpinfo` is titled with an `<h2><a name="module_NAME">NAME</a></h2>` tag. While the `name=module_NAME` attribute allows linking to that section using a URL fragment (e.g `info.php#module_NAME`), it lacks discoverability because the `<a>` tag does not contain an `href` attribute. This is also highlighted in accessibility scans (in Firefox for instance). This adds a link to the `<a>` tag that links to the URL fragment, fixing the accessibility remark and improving the discoverability of the clickable section titles. Also contains minor CSS changes to account for the dark theme CSS.
878cb1c to
9b76b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was split away from #8958, which I proposed to make
phpinfoHTML output accessibility improvements with better contrast, in addition to the following change. For easier review, this PR only focuses on clickable module titles, while #8958 will focus on the contrast improvements.Each section of
phpinfois titled with an<h2><a name="module_NAME">NAME</a></h2>tag. While thename=module_NAMEattribute allows linking to that section using a URL fragment (e.ginfo.php#module_NAME), it lacks discoverability because the<a>tag does not contain anhrefattribute. This is also highlighted in accessibility scans (in Firefox for instance).This adds a link to the
<a>tag that links to the URL fragment, fixing the accessibility remark and improving the discoverability of the clickable section titles. Also contains minor CSS changes to account for the dark theme CSS.