Migrate GH Actions macos-10.05 to macos-11

[zeriyoshi]

macos-10.05 is deprecated and brownouting, CI is almost fails.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

[iluuu1994]

LGTM if the build passes

[iluuu1994]

@zeriyoshi I think macOS 11 disallows sudo by default, you might be able to just remove it from make install in push.yml and nightly.yml.

[zeriyoshi]

@iluuu1994
Thanks!

I did look at the logs, it appears that many libraries are already installed. Do I remove these from brew.yaml? Or leave it for clarity?

https://github.com/php/php-src/runs/7451974041

[devnexen]

I did look at the logs, it appears that many libraries are already installed. Do I remove these from brew.yaml? Or leave it for clarity?

That depends, the system libs are not updated as often as the brew counterparts nor they are necessarily the same e.g.

dcarlier@Davids-MacBook-Pro php-src % openssl version LibreSSL 2.8.3 dcarlier@Davids-MacBook-Pro php-src % /opt/homebrew/opt/openssl/bin/openssl version OpenSSL 3.0.5 5 Jul 2022 (Library: OpenSSL 3.0.5 5 Jul 2022)
I would recommend to keep some

[iluuu1994]

@zeriyoshi I think my previous assumption was wrong, sudo is still needed. Not sure if the error was related.

[zeriyoshi]

@devnexen
OK, I revert cleanup commit. thx!

@iluuu1994
I succeeded by adding make with brew. The install problem is solved, but the test results are puzzling. I will investigate further.

https://github.com/php/php-src/runs/7452896461

[zeriyoshi]

The problem could not be resolved during waking hours.
I will go to bed once. sorry.

For speedy fixes, please disregard this PR and correct the problem if it can be resolved.

[Ayesh]

Linking to the relevant changelog entry: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

[cmb69]

Any progress here? It seems that our macOS jobs are being cancelled for a while, so upgrading to macOS 11 appears to be somewhat urgent (also for the PHP-8.0 and PHP-8.1 branches).

[zeriyoshi]

@cmb69
I have been on hold because I could not figure out the cause of my current problem.
I was going to try to find the cause on my Intel Mac over the weekend.

CI is cancelled, but works fine except for the GH's takedown schedule.

I think the size of zend_long is wrong, any ideas?

https://github.com/php/php-src/runs/7453701653

[cmb69]

I think the size of zend_long is wrong, any ideas?

Are they possibly running on a different architecture? We might need to cater to that:

php-src/Zend/zend_long.h

Lines 25 to 28 in a398a2f

	/* This is the heart of the whole int64 enablement in zval. */
	#if defined(__x86_64__) || defined(__LP64__) || defined(_LP64) || defined(_WIN64)
	# define ZEND_ENABLE_ZVAL_LONG64 1
	#endif

[TimWolla]

@devnexen perhaps 👆?

[iluuu1994]

@cmb69

Are they possibly running on a different architecture?

Doesn't sound like this has changed.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

• Hardware specification for macOS virtual machines:
  • 3-core CPU (x86_64)

[devnexen]

I can definitely reproduce the error on rosetta mode in my mac M1.

[zeriyoshi]

@devnexen
Can you tell me the package and toolchain version you put in brew for reference?
I tried to reproduce on macOS 11 on Intel but could not reproduce the problem.

[zeriyoshi]

Perhaps it is incorrect to disable ZEND_ENABLE_ZVAL_LONG64. This will cause zend_long to be 32-bit even on 64-bit architectures.

[devnexen]

Or maybe it happens only in virtual environment ? after all, rosetta is just x86 64 emulation (it can t handle AVX instructions for example), I no longer have my old intel macos to confirm.

[devnexen]

@devnexen Can you tell me the package and toolchain version you put in brew for reference? I tried to reproduce on macOS 11 on Intel but could not reproduce the problem.

Same brew packages and I use mostly clang from xcode, however I m running monterey.

[nikic]

This is likely related to ZEND_DVAL_TO_LVAL_CAST_OK. Can you try force disabling it?

[nikic]

I see similar failures when doing a release build with clang on Linux.

[zeriyoshi]

@devnexen @nikic
I tried everything on weekend, but could not reproduce it in the end.
I will check about the clang. Thanks.

[zeriyoshi]

After confirming that it works properly, create a separate PR.

[zeriyoshi]

• clang is not updated with CommandLineTools updates
• However, it will be updated after Xcode is installed.
• I did not have Xcode installed on my Intel Mac

The above seems to be the conclusion.

On the other hand, I will create a separate PR as it turns out that the problem requires a change in implementation to be resolved.

[cmb69]

Great, now it works. Thank you!

I suggest to apply that PHP 8.0, and to merge upwards.

[zeriyoshi]

Thank you for suggesting!
I will it after CI succeeded :)