Fix GH-9090: Support assigning function pointers in FFI #9107
Conversation
|
Looks fine by me but cc @dstogov |
|
Thank you! On a quick glimpse, this looks good to me as well, but we should also check the calling convention compatibility ( |
| } | ||
|
|
||
| /* Ensure same arg count */ | ||
| dst_argc = dst_type->func.args ? zend_hash_num_elements(dst_type->func.args) : 0; |
There was a problem hiding this comment.
Does this need a check for C varags? Either way, a test for that would be nice.
There was a problem hiding this comment.
Thanks, added a variadic to the test.
There was a problem hiding this comment.
You should check
(src_type->attr & ZEND_FFI_ATTR_VARIADIC) == (dst_type->attr & ZEND_FFI_ATTR_VARIADIC)
Also it's make sense to add check for calling convention
src_type->func.abi == dst_type->func.abi
There was a problem hiding this comment.
Added those checks. Thank you.
105ce4b to
44c3558
Compare
| } | ||
|
|
||
| /* Ensure same arg count */ | ||
| dst_argc = dst_type->func.args ? zend_hash_num_elements(dst_type->func.args) : 0; |
There was a problem hiding this comment.
You should check
(src_type->attr & ZEND_FFI_ATTR_VARIADIC) == (dst_type->attr & ZEND_FFI_ATTR_VARIADIC)
Also it's make sense to add check for calling convention
src_type->func.abi == dst_type->func.abi
44c3558 to
3f70649
Compare
|
Thank you! |
No description provided.