Skip to content

Remove dead code in ext/random/random.c #9114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2022
Merged

Remove dead code in ext/random/random.c #9114

merged 1 commit into from
Jul 23, 2022

Conversation

TimWolla
Copy link
Member

My understanding is that this case is effectively the same as:

#9070 (comment)

@TimWolla TimWolla requested a review from cmb69 July 23, 2022 10:25
cmb69
cmb69 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Thank you!

@TimWolla TimWolla merged commit 395b6a9 into php:master Jul 23, 2022
@TimWolla TimWolla deleted the random-dead-code branch July 23, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: random
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @cmb69