zend defines attribute malloc for Win32 as returned pointer are not a…

[devnexen]

…liased

[iluuu1994]

The attribute looks fitting. Unfortunately, Microsoft seems to expect the attribute before the function signature though, whereas for CGG/Clang it's after. Not sure how we should handle that.

[cmb69]

A good idea, but I don't think it can work this way, since __declspec() needs to be at the beginning of the definition, while ZEND_ATTRIBUTE_MALLOC is currently at the end. :(

[iluuu1994]

@devnexen Personally I'd prefer if we added a new macro for __declspec(restrict) that was empty for non-Windows systems. This has two benefits:

1. We don't need duplication of the function signatures
2. Existing usages of ZEND_ATTRIBUTE_MALLOC won't break, as without the #ifndef ZEND_WIN32 they'd be in the wrong spot

[devnexen]

Sure we could do that way, I wanted not to add more noise to an already noisy declaration set especially some of them don t apply to windows :) but I ll follow your point.

[cmb69]

Do we really need a new macro here? Wouldn't ZEND_ATTRIBUTE_MALLOC work, if we put it at the beginning of the function declarations?

[cmb69]

Thank you!

[iluuu1994]

Thanks! I wasn't aware GCC/Clang accept the attribute in both places.