Declare ext/zend_test constants in stubs #9135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
approved these changes
Jul 25, 2022
| @@ -295,6 +295,11 @@ static const zend_function_entry class_ZendTestNS2_ZendSubNS_Foo_methods[] = { | |||
| ZEND_FE_END | |||
| }; | |||
|
|
|||
| static void register_test_symbols(int module_number) | |||
| { | |||
| REGISTER_LONG_CONSTANT("ZEND_TEST_DEPRECATED", 42, CONST_CS | CONST_PERSISTENT | CONST_DEPRECATED); | |||
There was a problem hiding this comment.
This adds CONST_CS which is a NOOP. Should CONST_CS be removed from the stub generator?
There was a problem hiding this comment.
Yep. I've already added it to my to-do list to remove const_cs, and will implement it as soon as all constants are migrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.