Fix bug #79451: Using DOMDocument->replaceChild on doctype causes double free #9201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 2, 2022
ext/dom/node.c
Outdated
| @@ -1000,7 +1001,7 @@ PHP_METHOD(DOMNode, replaceChild) | |||
| zval *id, *newnode, *oldnode; | |||
| xmlNodePtr children, newchild, oldchild, nodep; | |||
| dom_object *intern, *newchildobj, *oldchildobj; | |||
| int foundoldchild = 0, stricterror; | |||
| int foundoldchild = 0, stricterror, replacedoctype = 0; | |||
There was a problem hiding this comment.
Suggested change
| int foundoldchild = 0, stricterror, replacedoctype = 0; | |
| int foundoldchild = 0, stricterror; | |
| bool replacedoctype = false; |
PHP 8.0 uses C99 so might as well use bool :)
But even better would to move into the branch where it is only relevant.
|
The fix for 8.1 and above is different, and I don't know how to do it. So reoppening |
|
@Girgias I think the only think that needs to be done is switch from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=79451
We have to reset intSubset if replacing doctype with another doctype node.