Skip to content

Improve phrasing in argument value errors in ext/random #9206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2022

Conversation

TimWolla
Copy link
Member

This rephrases the error message for argument errors to be a proper English
sentence.

This rephrases the error message for argument errors to be a proper English
sentence.
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@TimWolla TimWolla merged commit 53ca24d into php:master Jul 31, 2022
@TimWolla TimWolla deleted the random-argument-value-error-wording branch July 31, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants