Fix GH-9227: Trailing dots and spaces in filenames are ignored #9229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Windows ignores trailing dots and spaces in filenames, we catch that ourselves to avoid confusion with the respective filenames without these characters.
Girgias
reviewed
Aug 2, 2022
We split the failing SPL test, and exclude testing the trailing dot. We adapt the test expectations for the file tests; while the former error message was more suitable, we now get the file not found due to https://github.com/php/php-src/blob/150456eaa22ea11e25331f9d0d0645281fc98f03/Zend/zend_virtual_cwd.c#L1142
cmb69
commented
Aug 3, 2022
Zend/zend_virtual_cwd.c
Outdated
Comment on lines
1143
to
1146
| #ifdef ZEND_WIN32 | ||
| if (errno != EACCES) | ||
| #endif | ||
| errno = ENOENT; |
There was a problem hiding this comment.
This is a quick hack, but I wonder whether that wouldn't make sense on non Windows systems, too.
|
If there are no objections, I'll merge this by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Windows ignores trailing dots and spaces in filenames, we
catch that ourselves to avoid confusion with the respective filenames
without these characters.