Skip to content

Make pestr[n]dup infallible #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

Make pestr[n]dup infallible #9295

merged 1 commit into from
Aug 12, 2022

Conversation

iluuu1994
Copy link
Member

Fixes GH-9128

@iluuu1994 iluuu1994 requested a review from cmb69 August 11, 2022 09:46
@iluuu1994
Copy link
Member Author

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

@cmb69
Copy link
Member

cmb69 commented Aug 11, 2022

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

I tend to agree.

@devnexen
Copy link
Member

Alternatively we could make zend_strndup infallible itself, which would probably not be a bad idea.

I tend to agree.

seconded.

@iluuu1994 iluuu1994 force-pushed the infallible-pestrdup branch from 235e789 to 4516319 Compare August 12, 2022 09:25
@iluuu1994 iluuu1994 merged commit 98bdb7f into php:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 Awaiting requested review from cmb69

Assignees
No one assigned
Labels
Category: Engine Extension: standard SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pestr(n)dup() is not infallible
3 participants
@iluuu1994 @cmb69 @devnexen