Update expires format for session cookie

[TimWolla]

Even if DATE_FORMAT_COOKIE is not updated, at the very least regular cookies and sessions cookies should be consistent.

---

see GH-9200
see 15e3fcb

[derickr]

This looks good. I hadn't realised that this didn't go through the normal php_setcookie API. Should it?

Do see if you can add a test though.

[TimWolla]

Should it?

All things being equal, it should. I might look into this as a follow-up improvement.

Do see if you can add a test though.

I had a look at creating a test, but to my understanding this is non-trivial, unless I want to create a flaky test. As I can't fixate the current time, I can't control the expiry time. Even just adding some time amount X to the current time, might cause false failures if the second rolls over.

[cmb69]

I had a look at creating a test, but to my understanding this is non-trivial,

I think it would be sufficient to test the format, not any particular date.

[TimWolla]

I think it would be sufficient to test the format, not any particular date.

Yes, but this is also going to get ugly quickly: EXPECTHEADERS doesn't support regular expressions and while I could technically use headers_list(), this would require me to find the set-cookie header in there and then use preg_match() to verify the format. However based on my understanding preg_match() is not even guaranteed to exist, because pcre might not be compiled.

[cmb69]

I have to admit, that this test would be harder to write than it should, but you can rely on PCRE being available; it is a required extension.

[TimWolla]

but you can rely on PCRE being available; it is a required extension.

Oh, indeed. Not sure where I looked before to get the false impression that it isn't. I'll have a look at adding the test then.

[cmb69]

BTW, the fact that PCRE is required is the reason for us to bundle libpcre.

[cmb69]

Thank you! Looks good to me (assuming AppVeyor CI passed).