Replace RuntimeException in Randomizer::nextInt() by RandomException #9305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TimWolla |
Girgias
approved these changes
Aug 12, 2022
771bc83 to
73c46b5
Compare
We do now! @zeriyoshi Okay, that makes sense to me. Then this just needs to change the exception type for proper consistency. Please review 😃 |
In time for Beta 3, so that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, this exception likely should not really exist, because it's not really actionable by the user, but in any case it should not be a RuntimeException.
@zeriyoshi Is there a specific reason for this Exception? Should we just clamp a 64 bit value (which is the maximum generated size, even for user engines) to the upper 32 bits for 32 bit systems (which are the only systems that will ever throw the exception)?