Skip to content

Reduce observer overhead when restoring script from opcache #9413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

Reduce observer overhead when restoring script from opcache #9413

merged 3 commits into from
Aug 25, 2022

Conversation

dstogov
Copy link
Member

@dstogov dstogov commented Aug 24, 2022

No description provided.

@dstogov dstogov requested a review from bwoebi August 24, 2022 05:35
bwoebi
bwoebi approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you now have a difference in behaviour between the scenario of failure and no failure. But may be okay as it's an unrecoverable fatal error.

@dstogov
Copy link
Member Author

dstogov commented Aug 24, 2022

Technically you now have a difference in behaviour between the scenario of failure and no failure. But may be okay as it's an unrecoverable fatal error.

It's also possible to duplicate the loop(s) to keep original behavior for this case.
What do you prefer?

@bwoebi
Copy link
Member

bwoebi commented Aug 24, 2022

I do prefer proper correctness. At least in combination with extensions which sandbox a bailout at runtime...

@dstogov
Copy link
Member Author

dstogov commented Aug 24, 2022

I do prefer proper correctness. At least in combination with extensions which sandbox a bailout at runtime...

OK. I'll update the PR tomorrow morning.

@bwoebi
Copy link
Member

bwoebi commented Aug 25, 2022

That looks sensible to me, thanks Dmitry :-)

@dstogov dstogov merged commit 7f74a30 into php:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
Extension: opcache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstogov @bwoebi @staabm