Skip to content

Fix oci8/pdo_oci random test failures when run in parallel #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Contributor

fix #8348 (comment)

I seached CREATE in the ext/oci8/tests directory and almost all tests are conflicting (using the same name). This solution using a CONFLICTS file seems to be used also in other ext tests directories like mysql.

@mvorisek mvorisek changed the base branch from master to PHP-8.0 August 25, 2022 12:37
@cmb69 cmb69 closed this in be4dd60 Aug 25, 2022
@cmb69
Copy link
Member

cmb69 commented Aug 25, 2022

Thank you!

@mvorisek
Copy link
Contributor Author

One off topic question, why are the tests /w opcache by about 40% slower?

image

I would expect them to be about the same or faster.

@mvorisek mvorisek deleted the fix_oci8_conflicts branch August 25, 2022 13:25
@cmb69
Copy link
Member

cmb69 commented Aug 25, 2022

One off topic question, why are the tests /w opcache by about 40% slower?

I assume that is due to OPcache overhead, which may not pay off for a single test run.

@mvorisek
Copy link
Contributor Author

But that is brutal! Someone should probably look into the startup opcache delay, as the tests are usually very simple, so there should be minimal per initial code analysis overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants