Skip to content

Declare ext/standard constants in stubs - part 3 #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Declare ext/standard constants in stubs - part 3 #9427

merged 1 commit into from
Aug 26, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

cmb69
cmb69 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Side note: we should patch gen_stub.php at some time to no longer add the CONST_CS flag, since this does nothing as of PHP 8.0.0.

@kocsismate
Copy link
Member Author

Yep, definitely! This was my next plan 🙂

@kocsismate kocsismate merged commit ef72d53 into php:master Aug 26, 2022
@kocsismate kocsismate deleted the const-stanard3 branch August 26, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69