Fix GH-9308 GMP throws the wrong error when a GMP object is passed to gmp_init() #9490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to gmp_init()
iluuu1994
approved these changes
Sep 9, 2022
| --TEST-- | ||
| Bug GH-9308: GMP throws the wrong error when a GMP object is passed to gmp_init() | ||
| --SKIPIF-- | ||
| <?php if (!extension_loaded("gmp")) print "skip"; ?> |
There was a problem hiding this comment.
Normally we use die('skip explanation');. If there are multiple ifs the script would continue running.
There was a problem hiding this comment.
I copy pasted this from one of the other bug tests and didn't double check the section, will amend.
iluuu1994
reviewed
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging up is going to a bit of a PITA due to the changes which make GMP handle octal strings in regards to https://wiki.php.net/rfc/explicit_octal_notation