Skip to content

Declare ext/standard constants in stubs - part 7 #9505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

Declare ext/standard constants in stubs - part 7 #9505

merged 1 commit into from
Sep 8, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

cmb69
cmb69 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think this might still be eligible for PHP-8.2, but only targeting master is certainly fine.

@kocsismate
Copy link
Member Author

Thank you for the review!

I think this might still be eligible for PHP-8.2, but only targeting master is certainly fine.

Ah, as always, I targeted the wrong branch. But my feature branch was created from PHP-8.2 :)

@kocsismate kocsismate changed the base branch from master to PHP-8.2 September 8, 2022 10:54
@kocsismate kocsismate merged commit 3227d04 into php:PHP-8.2 Sep 8, 2022
@kocsismate kocsismate deleted the const-standard7 branch September 8, 2022 11:57
kocsismate added a commit that referenced this pull request Sep 8, 2022
@kocsismate
Merge branch 'PHP-8.2'
340b94e 
* PHP-8.2:
  Declare ext/standard constants in stubs - part 7 (#9505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69