Prevent FPM tests from failing due to expose_php #9508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a php.ini is installed in $PREFIX containing expose_php = off, a number of FPM tests fail due to a missing-but-expected X-Powered-By header. This change injects an "expose_php = on" into the fpm pool config.
This fails to fix one test - sapi/fpm/tests/status-listen.phpt - which continues to fail as the status pool doesn't pick up php_flag options from the fpm pool config. I'll see about applying php_ flags/values to the status pool, but leave that for a separate pull request as it's a more significant change.